Skip to content

Pre-install all CI compilers in base Docker image - #7879

Merged
huydhn merged 1 commit into
mainfrom
huydhn/preinstall-compilers
Mar 25, 2026
Merged

Pre-install all CI compilers in base Docker image#7879
huydhn merged 1 commit into
mainfrom
huydhn/preinstall-compilers

Conversation

@huydhn

@huydhn huydhn commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Pre-install GCC 11, GCC 13, GCC 14, clang 15, and clang 18 in the base image so that the setup-linux action only needs to activate the right compiler instead of downloading/installing at runtime. This reduces CI job latency and removes fragile S3/dnf dependencies from the critical path.

Also register clang runtime library directories with ldconfig so that libclang_rt.asan.so is discoverable by the linker without LD_LIBRARY_PATH workarounds in CI scripts.

@huydhn
huydhn requested a review from atalman March 24, 2026 23:19
@vercel

vercel Bot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
torchci Ignored Ignored Preview Mar 24, 2026 11:25pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2026
Pre-install GCC 11, 13, 14 (via gcc-toolset) and clang 15, 18 (from S3
tarballs) in the base image so that the setup-linux action only needs to
activate the right compiler instead of downloading/installing at runtime.

The manylinux_2_28 base image (AlmaLinux 8) ships with GCC 8 as the
system default and bundles gcc-toolset-12 under /usr/local/bin. All
needed toolset versions are now pre-installed under /opt/rh/gcc-toolset-*.

Also register clang runtime library directories with ldconfig so that
libclang_rt.asan.so is discoverable by the linker without LD_LIBRARY_PATH
workarounds in CI scripts.

Authored with Claude.
@huydhn
huydhn force-pushed the huydhn/preinstall-compilers branch from c493de6 to a9481ae Compare March 24, 2026 23:25
@huydhn
huydhn merged commit 1972edf into main Mar 25, 2026
13 checks passed
@huydhn
huydhn deleted the huydhn/preinstall-compilers branch March 25, 2026 00:35
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Mar 27, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: #178361
Approved by: https://github.com/atalman
Copilot AI pushed a commit to pytorch/pytorch that referenced this pull request Mar 27, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: #178361
Approved by: https://github.com/atalman

Co-authored-by: Xia-Weiwen <12522207+Xia-Weiwen@users.noreply.github.com>
AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 31, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: pytorch#178361
Approved by: https://github.com/atalman
pytorch-bot Bot pushed a commit to pytorch/pytorch that referenced this pull request Apr 2, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: #178361
Approved by: https://github.com/atalman
IvanKobzarev pushed a commit to IvanKobzarev/pytorch that referenced this pull request Apr 3, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: pytorch#178361
Approved by: https://github.com/atalman
nklshy-aws pushed a commit to nklshy-aws/pytorch that referenced this pull request Apr 7, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: pytorch#178361
Approved by: https://github.com/atalman
gplutop7 pushed a commit to gplutop7/pytorch that referenced this pull request Jul 15, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: pytorch#178361
Approved by: https://github.com/atalman
aws-kingrj pushed a commit to amazon-contributing/upstream-to-pytorch that referenced this pull request Jul 29, 2026
The logic has been moved to pytorch/test-infra#7879, so here we just need to choose the right compiler.
Pull Request resolved: pytorch#178361
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants